RF+API: add qform, sform code 1 for parrec2nii #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in nipy#478
Current coverage is 93.97% (diff: 100%)@@ master #481 diff @@
==========================================
Files 166 166
Lines 21831 21828 -3
Methods 0 0
Messages 0 0
Branches 2326 2326
==========================================
- Hits 20515 20512 -3
- Misses 884 885 +1
+ Partials 432 431 -1
|
From review by CM.
|
LGTM. |
Use decorators to patch in the stuff we need for testing.
|
Can't really comment on the Mock stuff, but as far as I can see it's fine. @ilogue, can you have a look? |
|
LGTM |
|
Thanks for reviews - merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #478