Skip to content

RF+API: add qform, sform code 1 for parrec2nii #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 19, 2016

Conversation

matthew-brett
Copy link
Member

As discussed in #478

@coveralls
Copy link

coveralls commented Aug 15, 2016

Coverage Status

Coverage increased (+0.0004%) to 95.951% when pulling 44efa75 on matthew-brett:parrec-codes-to-1 into 42959a3 on nipy:master.

@codecov-io
Copy link

codecov-io commented Aug 15, 2016

Current coverage is 93.97% (diff: 100%)

Merging #481 into master will decrease coverage by <.01%

@@             master       #481   diff @@
==========================================
  Files           166        166          
  Lines         21831      21828     -3   
  Methods           0          0          
  Messages          0          0          
  Branches       2326       2326          
==========================================
- Hits          20515      20512     -3   
- Misses          884        885     +1   
+ Partials        432        431     -1   

Powered by Codecov. Last update 42959a3...12afd01

@coveralls
Copy link

coveralls commented Aug 16, 2016

Coverage Status

Coverage increased (+0.0004%) to 95.951% when pulling bf8f087 on matthew-brett:parrec-codes-to-1 into 42959a3 on nipy:master.

@effigies
Copy link
Member

LGTM.

Use decorators to patch in the stuff we need for testing.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 95.946% when pulling 12afd01 on matthew-brett:parrec-codes-to-1 into 42959a3 on nipy:master.

@effigies
Copy link
Member

Can't really comment on the Mock stuff, but as far as I can see it's fine. @ilogue, can you have a look?

@JasperVanDenBosch
Copy link
Contributor

LGTM

@matthew-brett
Copy link
Member Author

Thanks for reviews - merging.

@matthew-brett matthew-brett merged commit 693c36a into nipy:master Aug 19, 2016
@matthew-brett matthew-brett deleted the parrec-codes-to-1 branch August 19, 2016 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants